Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

mpt_api_client/rql/query_builder.py (1)

2-10: ⚠️ Potential issue | 🔴 Critical

QueryValue now causes runtime TypeError in isinstance paths; split scalar vs list types.

Line 10 adds Iterable[str] into QueryValue, and QueryValue is used in runtime isinstance(...) checks (Line 105, Line 143). That raises TypeError: isinstance() argument 2 cannot be a parameterized generic, which matches the failing pipeline traces.

💡 Proposed fix

 from decimal import Decimal
 from typing import Any, Self, override

 Numeric = int | float | Decimal
-
-QueryValue = str | bool | dt.date | dt.datetime | Numeric | Iterable[str]  # noqa:WPS221
+QueryScalarValue = str | bool | dt.date | dt.datetime | Numeric
+QueryListValue = list[QueryScalarValue] | tuple[QueryScalarValue, ...] | set[QueryScalarValue]
+QueryValue = QueryScalarValue
+QueryArgumentValue = QueryScalarValue | QueryListValue

@@
-def parse_kwargs(query_dict: dict[str, QueryValue]) -> list[str]:  # noqa: WPS231
+def parse_kwargs(query_dict: dict[str, QueryArgumentValue]) -> list[str]:  # noqa: WPS231

@@
-        **kwargs: QueryValue,
+        **kwargs: QueryArgumentValue,

@@
-def query_value_str(value: Any) -> str:
+def query_value_str(value: Any) -> str:
     """Converts a value to string for use in RQL queries."""
-    if isinstance(value, QueryValue):
+    if isinstance(value, QueryScalarValue):
         value = RQLValue(value)

@@
 def rql_encode(op: str, value: Any) -> str:
@@
-    if op not in constants.LIST and isinstance(value, QueryValue | RQLValue | RQLProperty):
+    if op not in constants.LIST and isinstance(value, QueryScalarValue | RQLValue | RQLProperty):
         return query_value_str(value)

#!/bin/bash
set -euo pipefail

# Verify root cause exists in current tree (read-only checks).
rg -nP '^\s*QueryValue\s*=.*Iterable\[[^]]+\]' mpt_api_client/rql/query_builder.py
rg -nP '\bisinstance\([^)]*,\s*QueryValue(\s*\||\s*\))' mpt_api_client/rql/query_builder.py

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@mpt_api_client/rql/query_builder.py` around lines 2 - 10, QueryValue
currently includes a parameterized generic (Iterable[str]) which causes
TypeError when used in runtime isinstance checks; split the alias into a scalar
union and a non-parameterized iterable alias, then update the isinstance checks
to use those concrete symbols. Concretely: replace QueryValue with two aliases
such as QueryScalarValue = str | bool | dt.date | dt.datetime | Numeric and
QueryIterableValue = Iterable (or Iterable[Any]/collections.abc.Iterable without
type parameters), or define QueryListValue = Iterable[str] only for type hints,
and update any runtime isinstance(...) use (the checks around the previous
QueryValue usage) to test against QueryScalarValue's concrete types (e.g., (str,
bool, dt.date, dt.datetime, int, float, Decimal)) or check isinstance(value,
collections.abc.Iterable) for lists; keep the type-only parameterized
Iterable[str] for typing annotations but never pass a parameterized generic into
isinstance.

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

mpt_api_client/rql/query_builder.py (1)

2-10: ⚠️ Potential issue | 🔴 Critical

Pipeline failure: mypy requires type parameters for Iterable.

The CI is failing with Missing type parameters for generic type 'Iterable' [type-arg]. However, adding a type parameter (e.g., Iterable[str]) will cause a runtime TypeError on line 143 because isinstance() cannot accept parameterized generics.

The previous review comment's suggested fix remains the correct approach—split into scalar and collection aliases:

💡 Recommended refactor

-from collections.abc import Iterable
 from decimal import Decimal
 from typing import Any, Self, override

 Numeric = int | float | Decimal
-
-QueryValue = str | bool | dt.date | dt.datetime | Numeric | Iterable  # noqa:WPS221
+QueryScalarValue = str | bool | dt.date | dt.datetime | Numeric
+QueryListValue = list[QueryScalarValue] | tuple[QueryScalarValue, ...] | set[QueryScalarValue]
+QueryValue = QueryScalarValue  # For scalar operators (eq, ne, lt, etc.)
+QueryArgumentValue = QueryScalarValue | QueryListValue  # For kwargs accepting both

Then update function signatures and runtime checks accordingly:

• parse_kwargs: use QueryArgumentValue
• RQLQuery.__init__(**kwargs): use QueryArgumentValue
• Line 143: use QueryScalarValue in the isinstance check
• Line 145: keep list | tuple | set for the collection branch

,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@mpt_api_client/rql/query_builder.py` around lines 2 - 10, Define separate
scalar and collection aliases instead of using a parameterless Iterable: add
QueryScalarValue = str | bool | dt.date | dt.datetime | Numeric and
QueryCollectionValue = list | tuple | set and then define QueryArgumentValue =
QueryScalarValue | QueryCollectionValue; update function/type annotations to use
QueryArgumentValue (e.g., parse_kwargs and RQLQuery.__init__), change the
runtime isinstance check that currently uses Iterable to check against
QueryScalarValue (for scalars) and keep the collection branch using list | tuple
| set so isinstance() calls remain valid at runtime.

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

mpt_api_client/rql/query_builder.py (1)

10-10: ⚠️ Potential issue | 🟠 Major

Unresolved from prior review: split scalar vs collection aliases instead of widening QueryValue.

Line 10 still broadens QueryValue to Iterable, so scalar operators (eq/ne/lt/...) now accept list/tuple/set and serialize them instead of failing fast. That changes behavior beyond the in/out use case.

Proposed refactor

-from collections.abc import Iterable
 from decimal import Decimal
 from typing import Any, Self, override

 Numeric = int | float | Decimal
-
-QueryValue = str | bool | dt.date | dt.datetime | Numeric | Iterable  # type: ignore[type-arg] # noqa: WPS221
+QueryScalarValue = str | bool | dt.date | dt.datetime | Numeric
+QueryListValue = list[QueryScalarValue] | tuple[QueryScalarValue, ...] | set[QueryScalarValue]
+QueryValue = QueryScalarValue
+QueryArgumentValue = QueryScalarValue | QueryListValue

-def parse_kwargs(query_dict: dict[str, QueryValue]) -> list[str]:  # noqa: WPS231
+def parse_kwargs(query_dict: dict[str, QueryArgumentValue]) -> list[str]:  # noqa: WPS231

     def __init__(  # noqa: WPS211
         self,
         namespace_: str | None = None,  # noqa: WPS120
-        **kwargs: QueryValue,
+        **kwargs: QueryArgumentValue,
     ) -> None:

#!/bin/bash
set -euo pipefail

# Verify alias split and where each alias is used
rg -n "^(Numeric|QueryScalarValue|QueryListValue|QueryArgumentValue|QueryValue)\s*=" mpt_api_client/rql/query_builder.py

# Verify scalar operators still accept scalar-only alias
rg -n "def (eq|ne|lt|le|gt|ge|like|ilike)\(self, value:" mpt_api_client/rql/query_builder.py

# Verify kwargs/parser accept scalar + collection arguments
rg -n "def parse_kwargs|def __init__\(" mpt_api_client/rql/query_builder.py

# Verify runtime branch separation remains explicit
rg -n "if op not in constants\.LIST|if op in constants\.LIST" mpt_api_client/rql/query_builder.py

As per coding guidelines, "Typing and type aliases... project config enforces strict typing and mypy checks; ensure proper imports and type hints conform to strict settings."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@mpt_api_client/rql/query_builder.py` at line 10, The QueryValue alias was
widened to include Iterable which lets scalar operators accept collections;
split the alias into explicit QueryScalarValue (str | bool | dt.date |
dt.datetime | Numeric) and QueryListValue (Iterable[QueryScalarValue]) and use a
union QueryArgumentValue = QueryScalarValue | QueryListValue (or keep QueryValue
as the union) so scalar-only methods (eq, ne, lt, le, gt, ge, like, ilike)
accept only QueryScalarValue signatures while in/out and list-handling code uses
QueryListValue; update type hints in the eq/ne/... method signatures,
parse_kwargs and __init__ to accept the correct aliases, and ensure runtime
branches still check operators against constants.LIST where needed (e.g., in
serialize/parse code) to preserve behavior and satisfy mypy.

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro